[PATCH] D73175: [llvm-readobj][test] - Remove --symbols --dyn-syms part from Object/readobj-shared-object.test.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 01:55:01 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/symbols.test:5
 ## Case 1: Test how llvm-readobj and llvm-readelf dumps symbols.
+## a) Check relocatable objects.
 # RUN: yaml2obj %s --docnum=1 -o %t64
----------------
It feels weird to me that we test relocatable and shared objects, but not regular ET_EXEC executables. Why do shared objects need specifically testing?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73175/new/

https://reviews.llvm.org/D73175





More information about the llvm-commits mailing list