[PATCH] D73193: [llvm-readelf] - Improve dumping of objects without a section header string table.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/sections-no-section-header-string-table.test:46
+# LLVM-NEXT:   }
+# LLVM-NEXT: error: '[[FILE]]': a section [index 2] has an invalid sh_name (0x1) offset which goes past the end of the section name string table
+
----------------
Not directly related to this change, but I'd like to see this changed to a warning at some point. It's annoying that we can't dump the rest of the table in this case, and there's no fundamental reason why we can't.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73193/new/

https://reviews.llvm.org/D73193