[PATCH] D73318: Print discriminators when printing .debug_line in GNU style.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Is there a particular reason to restrict this to GNU style? I think it's okay to expand on the LLVM style too, but might be worth getting more opinions on it.



================
Comment at: llvm/test/tools/llvm-symbolizer/output-style-discriminator.test:1
+Check that llvm-symbolizer prints line-table discriminators properly.
+
----------------
Could you add a leading '#' character here, (i.e. '# Check') to more clearly show that this is a comment. It helps improve readability.

I'd also rename this test to simply 'discriminator.test', and test both output styles' behaviour.


================
Comment at: llvm/test/tools/llvm-symbolizer/output-style-discriminator.test:3
+
+RUN: llvm-symbolizer --output-style=GNU -f -obj=%p/Inputs/discrim 0x400590 0x400575 | FileCheck %s
+
----------------
This is very much a personal nit of mine, but I know others have agreed in the past: please use consistently double-dashes for long options, and single-dashes for single-letter options (in other words "-obj" -> "--obj").


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73318/new/

https://reviews.llvm.org/D73318