[PATCH] D73169: [llvm-readobj] - Add a test for --dyn-symbols when there are no dynamic symbols.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 00:42:08 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test:286
+
+## Case 8: Check what we do when file does not have any dynamic symbols.
+# RUN: yaml2obj %s --docnum=7 -o %t7
----------------
MaskRay wrote:
> > does not have any dynamic symbols.
> 
> when the dynamic symbol table does not exist.
That makes me think like we should have three different cases:
1) Table does not exist.
2) Table exists, but is size 0.
3) Table exists, but only contains the null symbol.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73169/new/

https://reviews.llvm.org/D73169





More information about the llvm-commits mailing list