[PATCH] D73255: [ELF][PowerPC] Support R_PPC_COPY and R_PPC64_COPY

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Aside from a minor nit I have no more comments, looks fine to me.



================
Comment at: lld/test/ELF/ppc-reloc-copy.s:9
+
+# RUN: llvm-mc -filetype=obj -triple=powerpc64 %p/Inputs/relocation-copy.s -o %t1.o
+# RUN: ld.lld -shared %t1.o -soname=so -o %t1.so
----------------
It was a bit strange to see `t1` again.
I'd suggest to rename `t1.o`, `t1.so`, `t.o` and `t` to something else.
Perhaps use `ppc`/`ppc64` suffixes somewhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73255/new/

https://reviews.llvm.org/D73255