[PATCH] D73167: Don't separate imp/expl def handling for call site params

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:636
 
-    SmallVector<unsigned, 4> ExplicitFwdRegDefs;
-    SmallVector<unsigned, 4> ImplicitFwdRegDefs;
-    getForwardingRegsDefinedByMI(*I, ExplicitFwdRegDefs, ImplicitFwdRegDefs);
-    if (ExplicitFwdRegDefs.empty() && ImplicitFwdRegDefs.empty())
+    SmallSetVector<unsigned, 4> FwdRegDefs;
+    getForwardingRegsDefinedByMI(*I, FwdRegDefs);
----------------
dstenb wrote:
> djtodoro wrote:
> > Perhaps we should add a comment here describing what the `FwdRegDefs` is used for, or rename the variable.
> My naming imagination was a bit lackluster, so I added a comment.
nice, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73167/new/

https://reviews.llvm.org/D73167