[PATCH] D73294: [GWP-ASan] enable/disable and fork support.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 17:38:28 PST 2020


hctim accepted this revision.
hctim added a comment.
This revision is now accepted and ready to land.

LGTM with `installAtFork()` and `cond_wait()` comments.



================
Comment at: compiler-rt/lib/gwp_asan/tests/enable_disable.cpp:51
+  pthread_mutex_lock(&Mutex);
+  ThreadReady = true;
+  pthread_cond_signal(&Conditional);
----------------
I don't see why this value is needed - we don't expect someone else to send the cond_signal for this conditional, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73294/new/

https://reviews.llvm.org/D73294





More information about the llvm-commits mailing list