[PATCH] D73305: [gwp-asan] Implement malloc_iterate.

[Mitch Phillips via Phabricator via llvm-commits]

hctim accepted this revision.
hctim added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/gwp_asan/guarded_pool_allocator.cpp:183
 
+void GuardedPoolAllocator::iterate(void *Base, size_t Size, iterate_callback cb,
+                                   void *Arg) {
----------------
Nit: `Cb`


================
Comment at: compiler-rt/lib/gwp_asan/guarded_pool_allocator.h:107
+  typedef void (*iterate_callback)(uintptr_t base, size_t size, void *arg);
+  // List all allocations with start addresses within [Base, Base + Size).
+  // Must be called while the allocator is disabled. The callback can not
----------------
```
// Execute the callback `Cb()` for every allocation that lies between [Base, Base + Size)
```


================
Comment at: compiler-rt/lib/gwp_asan/guarded_pool_allocator.h:110
+  // allocate.
+  void iterate(void *Base, size_t Size, iterate_callback cb, void *Arg);
+
----------------
Nit: `Cb`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73305/new/

https://reviews.llvm.org/D73305