[PATCH] D73296: [mlir] Add MemRefTypeBuilder and refactor some MemRefType::get().

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added a comment.

I personally love the API with chainable calls but we should really get @rriddle 's buyin on this.
I would change the return by reference to just return a new type by value: Types (and recently Values) are small value-type wrappers around a pointer, we should use value semantics everywhere.
Also, if @rriddle agrees to go this way, can we hide MemRef::get and friends from the public API and advertise this as the way to go?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73296/new/

https://reviews.llvm.org/D73296