[PATCH] D72973: using symbol index+symbol name + storage mapping class as label for llvm-objdump -D

[Digger via Phabricator via llvm-commits]

DiggerLin marked an inline comment as done.
DiggerLin added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:345
 
-typedef std::vector<std::tuple<uint64_t, StringRef, uint8_t>> SectionSymbolsTy;
+typedef std::vector<std::tuple<uint64_t, StringRef, uint8_t, int64_t>>
+    SectionSymbolsTy;
----------------
jasonliu wrote:
> I probably need some time to think over this interface change. But is there a reason we choose a signed value to represent a symbol index?
in the xcoffobject file , a  unsigned 32 bits symbol index is enough for both 32bits xcoff and 64bits xcoff. but in the llvm-objdump. it add some section name a fake symbol name, we need to put the -1 as symbol index to identificate a fake symbol name. So we use int64_t here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72973/new/

https://reviews.llvm.org/D72973