[PATCH] D72802: [mlir] Introduce bare ptr calling convention for MemRefs in LLVM dialect

Diego Caballero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 13:52:17 PST 2020


dcaballe planned changes to this revision.
dcaballe added a comment.

Thank you both for the feedback! It makes sense to me now. Let me rework this following your suggestions. 
Just to recap, these are the pending issues:

- LLVMTypeConverter composability/scalability: To be addressed following @mehdi_amini and @ftynse suggestions.
- `populate*` functions scalability: No good solution for now. To be addressed in a separate commit (remove most of the `populate*` functions and make conversion patterns public could work)?
- Enable bare pointer calling conversion in JITRunner
- Do not expand scope of `replaceUsesOfBlockArgument`: Changes on `replaceUsesOfBlockArgument` seem necessary. Waiting for any other suggestions here (@rriddle?).

Please, let me know if I'm missing something or you have any other concerns before I proceed.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72802/new/

https://reviews.llvm.org/D72802





More information about the llvm-commits mailing list