[PATCH] D72526: [Matrix] Mark expressions shared between multiple remarks.

[Adam Nemet via Phabricator via llvm-commits]

anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:947
+
+    Value *Root;
 
----------------
Please comment these two.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1123
+      assert(SI != Shared.end());
+      if (SI->second.size() > 1 && !ParentShared) {
+        for (Value *S : SI->second) {
----------------
Do we even need to run find if ParentShared?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72526/new/

https://reviews.llvm.org/D72526