[PATCH] D72453: [Matrix] Add optimization remarks for matrix expression.

[Adam Nemet via Phabricator via llvm-commits]

anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

I think that in the description/commit log you want to say a bit on the motivation, like why it's useful to observe these matrix expression in this form.

LGTM!



================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:973
+
+    unsigned getNumShapeArgs(CallInst *CI) const {
+      if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(CI)) {
----------------
nit: This feels like a static utility function outside of this class, somewhere where we describe other properties of the intrinsics.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:991
+    /// (function) external address or a stack address, for other values we
+    /// either print the constant or scalar/matrix for other values.
+    void write(Value *V) {
----------------
"scalar"/"matrix"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72453/new/

https://reviews.llvm.org/D72453