[PATCH] D73235: [GlobalMerge] Preserve symbol visibility when merging globals

[Michael Spang via Phabricator via llvm-commits]

mspang added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/global-merge-hidden-minsize.ll:18
+; CHECK: .globl y
+; CHECK: .hidden y
----------------
efriedma wrote:
> Missing CHECK lines to verify the globals were actually merged.
Added them. I wasn't sure if we needed to, since the command line is not asking for this specific optimization and the bug is just that we end up with wrong visibility. But I think I agree with you, better to fail if this case isn't merged so we can update the test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73235/new/

https://reviews.llvm.org/D73235