[PATCH] D73254: [ELF] Rename relocateOne() to relocate() and pass `Relocation` to it

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 3 inline comments as done.
MaskRay added inline comments.


================
Comment at: lld/ELF/Symbols.cpp:102
     // symbols has the `STO_MIPS_MICROMIPS` flag in the `st_other`
-    // field. Unfortunately, the `MIPS::relocateOne()` method has
+    // field. Unfortunately, the `MIPS::relocate()` method has
     // a symbol value only. To pass type of the symbol (regular/microMIPS)
----------------
@atanasyan Looks like the `relocateOne(..., RelType type, ...)` -> relocate(..., const Relocation &rel, ...)` change (this patch) may benefit MIPS as well?


================
Comment at: lld/ELF/Target.h:246
     error(getErrorLocation(loc) + "improper alignment for relocation " +
-          lld::toString(type) + ": 0x" + llvm::utohexstr(v) +
+          lld::toString(rel.type) + ": 0x" + llvm::utohexstr(v) +
           " is not aligned to " + Twine(n) + " bytes");
----------------
nickdesaulniers wrote:
> Are the changes to this file necessary? Is the full `Relocation` object used?
This is for a future change: adding `Symbol *` information to the diagnostic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73254/new/

https://reviews.llvm.org/D73254