[PATCH] D72829: Implement -fsemantic-interposition

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 09:49:32 PST 2020


MaskRay added a comment.

In D72829#1835933 <https://reviews.llvm.org/D72829#1835933>, @serge-sans-paille wrote:

> Add Release note and doc. @MaskRay can you confirm current state is ok?


I feel that we are still behind a complete `-fsemantic-interposition`... I don't know whether we should mention that the option is experimental.



================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:487
+
+  if (Context.getLangOpts().SemanticInterposition)
+    // Require various optimization to respect semantic interposition.
----------------
This should also check -fno-pic -fpie vs -fpic.

In GCC, only -fpic -fPIC enable semantic interposition.

-fsemantic-interpositions seems a no-op with -fno-pic or -fpie.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72829/new/

https://reviews.llvm.org/D72829





More information about the llvm-commits mailing list