[PATCH] D73105: [llvm-readobj] - Add a test for --hash-table option.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 08:01:24 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/hash-table.test:91-92
+  Machine: EM_X86_64
+  SHOff:   0x0
+  SHNum:   0
+Sections:
----------------
Whilst I see what you're doing here, I think the test would be less confusing if you used llvm-objcopy --strip-sections to remove the section header table. You could then use the same input and checks as the first test case(s).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73105/new/

https://reviews.llvm.org/D73105





More information about the llvm-commits mailing list