[PATCH] D73044: {tablegen] Emit string literals instead of char arrays

Thu Jan 23 07:52:13 PST 2020

ldrumm added a comment.

In D73044#1836244 <https://reviews.llvm.org/D73044#1836244>, @broadwaylamb wrote:

> Hello @ldrumm,
>
> Sorry, I had to revert this commit in e464b31c1565204e3be114d043bcbf4de61fe2e9 <https://reviews.llvm.org/rGe464b31c1565204e3be114d043bcbf4de61fe2e9>, because it broke some Windows builds:
>  http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13870

Understood.
It looks like tablegen command-line options are dotted over `llvm/lib/Tablegen` and `utils/Tablegen` and the clang tablegen binary just links against the llvm/lib/Tablegen code, but as I only built llvm, not clang the tests all passed for me. Given this option can only affect the llvm-tablegen utility (it's use is in a private header of the llvm-tablegen source tree), it seems like we need to detect this with cmake. I'll update the patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73044/new/

https://reviews.llvm.org/D73044