[PATCH] D73168: Improvements to call site register worklist

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 07:34:12 PST 2020


dstenb marked 4 inline comments as done.
dstenb added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:665
+                   "Can't handle a register that is described by itself");
+            // The worklist register was described by a non-callee saved
+            // register. Add the new register to the worklist if not already
----------------
djtodoro wrote:
> `The register worklist` ?
"The worklist register" is perhaps a bit poorly phrased, or awkward to read. I meant "The register in the worklist". Perhaps it should just say "ParamFwdReg"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73168/new/

https://reviews.llvm.org/D73168





More information about the llvm-commits mailing list