[PATCH] D73176: [ARM] Fix dropped dollar sign from symbols in branch targets
Momchil Velikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 23 07:07:15 PST 2020
chill added inline comments.
================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6051
+ // $42 -> immediate
+ // $foo -> symbol name
S = Parser.getTok().getLoc();
----------------
What if we have here `$ foo`, i.e. whitespace after the dollar? We should not paste together two separate tokens `$` and `<whatever>` to form an identifier, `$foo`, `$12` are identifiers, but `$ 12` is not.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73176/new/
https://reviews.llvm.org/D73176
More information about the llvm-commits
mailing list