[PATCH] D72888: [mlir] Add baseAttr to TypedArrayAttrBase.

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 06:03:19 PST 2020


ftynse added a comment.

I reverted this change since it broke dependent projects, and the modeling generally looks incorrect.

`baseAttr` is intended to be used in the decorator classes that are not proper attributes themselves, but only add additional constraints to the existing attributes. For example, default-valued attributes of type XAttr don't need the value to be constructed, but they are still attributes of type XAttr. Array attributes of type XArrayAttr are _not_ XAttr.  If you need the element attribute for some reason, store it in a different tablegen field. Please also specify _why_ you need this change in the commit message, not only the contents of the change (https://llvm.org/docs/DeveloperPolicy.html#commit-messages).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72888/new/

https://reviews.llvm.org/D72888





More information about the llvm-commits mailing list