[PATCH] D73264: [DWARF] Do not pass Version to DWARFExpression. NFCI.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin created this revision.
ikudrin added reviewers: rnk, dblaikie, probinson, aprantl, friss.
ikudrin added projects: debug-info, LLVM.
Herald added a subscriber: hiraditya.
Herald added a reviewer: JDevlieghere.
Herald added a reviewer: jhenderson.
ikudrin retitled this revision from "[DWARF] Do not pass Version to DWARFExtract. NFCI." to "[DWARF] Do not pass Version to DWARFExpression. NFCI.".

The `Version` was used only to determine the size of an operand of `DW_OP_call_ref`. The size was 4 for all versions apart from 2, but the `DW_OP_call_ref` operation was introduced only in DWARF3. Thus, the code may be simplified and using of `Version` may be eliminated.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73264

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
  llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
  llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
  llvm/tools/dsymutil/DwarfLinkerForBinary.cpp
  llvm/tools/llvm-dwarfdump/Statistics.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73264.239848.patch
Type: text/x-patch
Size: 10085 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200123/5f39da79/attachment.bin>