[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 01:51:36 PST 2020


evgeny777 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/GlobalSplit.cpp:116
+    if (GV.hasMetadata(LLVMContext::MD_vcall_visibility))
+      SplitGV->setVCallVisibilityMetadata(GV.getVCallVisibility());
   }
----------------
I think this needs a test. Removal of this code doesn't break anything


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71907/new/

https://reviews.llvm.org/D71907





More information about the llvm-commits mailing list