[PATCH] D73169: [llvm-readobj] - Add a test for --dyn-symbols when there are no dynamic symbols.

[George Rimar via Phabricator via llvm-commits]

grimar updated this revision to Diff 239811.
grimar marked an inline comment as done.
grimar retitled this revision from "[llvm-readobj] - Add a test for --dyn-symbols when there is no dynamic symbols." to "[llvm-readobj] - Add a test for --dyn-symbols when there are no dynamic symbols.".
grimar added a comment.

- Addressed review comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73169/new/

https://reviews.llvm.org/D73169

Files:
  llvm/test/Object/readobj-absent.test
  llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test


Index: llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
===================================================================
--- llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
+++ llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
@@ -282,3 +282,18 @@
   - Name: foo
   - Name: bar
   - Name: zed
+
+## Case 8: Check what we do when file does not have any dynamic symbols.
+# RUN: yaml2obj %s --docnum=7 -o %t7
+# RUN: llvm-readobj --dyn-symbols %t7 | FileCheck %s --check-prefix=NO-DYNSYM-LLVM
+# RUN: llvm-readelf --dyn-symbols %t7 | count 0
+
+# NO-DYNSYM-LLVM:      DynamicSymbols [
+# NO-DYNSYM-LLVM-NEXT: ]
+
+--- !ELF
+FileHeader:
+  Class:   ELFCLASS32
+  Data:    ELFDATA2LSB
+  Type:    ET_REL
+  Machine: EM_386
Index: llvm/test/Object/readobj-absent.test
===================================================================
--- llvm/test/Object/readobj-absent.test
+++ /dev/null
@@ -1,10 +0,0 @@
-## Don't crash if required information is absent
-# RUN: yaml2obj %s -o %t
-# RUN: llvm-readobj --dyn-syms %t
-
---- !ELF
-FileHeader:
-  Class:   ELFCLASS32
-  Data:    ELFDATA2LSB
-  Type:    ET_REL
-  Machine: EM_386


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73169.239811.patch
Type: text/x-patch
Size: 1130 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200123/d51229b9/attachment.bin>