[llvm] 5f6ff71 - [llvm-readobj][test] - Add a check for --dyn-syms.

Georgii Rymar via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 01:20:45 PST 2020


Author: Georgii Rymar
Date: 2020-01-23T12:20:19+03:00
New Revision: 5f6ff716417a7b150d7462a5c146208f65b3d984

URL: https://github.com/llvm/llvm-project/commit/5f6ff716417a7b150d7462a5c146208f65b3d984
DIFF: https://github.com/llvm/llvm-project/commit/5f6ff716417a7b150d7462a5c146208f65b3d984.diff

LOG: [llvm-readobj][test] - Add a check for --dyn-syms.

We have a `-dyn-symbols` option. It has a `--dyn-syms` alias
that is not tested in llvm-readobj tests currently.

There was a Object/readobj-elf-versioning.test where it is used,
but I've removed it in D73163. And also it is not the
right place to test it anyways.

Differential revision: https://reviews.llvm.org/D73164

Added: 
    

Modified: 
    llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test b/llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
index 19dfc0073cba..a473e47f30d8 100644
--- a/llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
+++ b/llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
@@ -69,11 +69,19 @@ ProgramHeaders:
     Sections:
       - Section: .dynsym
 
-## Case 2: Check the two-letter alias --dt is equivalent to the --dyn-symbols
+## Case 2: Check the output for aliases.
+## a) Check the two-letter alias --dt is equivalent to the --dyn-symbols
 ## full flag name.
 # RUN: llvm-readobj --dt %t1.so > %t.readobj-dt-alias
 # RUN: llvm-readobj --dyn-symbols %t1.so > %t.readobj-dt-no-alias
 # RUN: cmp %t.readobj-dt-alias %t.readobj-dt-no-alias
+## b) Check --dyn-syms equals --dyn-symbols, --dt for llvm-readobj.
+# RUN: llvm-readobj --dyn-syms %t1.so > %t.readobj-dyn-syms
+# RUN: cmp %t.readobj-dt-alias %t.readobj-dyn-syms
+## c) Check --dyn-syms equals --dyn-symbols for llvm-readelf.
+# RUN: llvm-readelf --dyn-syms %t1.so > %t.readelf-dyn-syms
+# RUN: llvm-readelf --dyn-symbols %t1.so > %t.readelf-dyn-symbols
+# RUN: cmp %t.readelf-dyn-symbols %t.readelf-dyn-syms
 
 ## Case 3: Check that we are able to dump the dynamic symbol table even when we have no program headers.
 ## In this case we find the table by it's type (SHT_DYNSYM) and ignore the DT_SYMTAB value.


        


More information about the llvm-commits mailing list