[PATCH] D73089: [SSAUpdater] Don't call ValueIsRAUWd upon single use replacement

Daniil Suchkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 00:58:13 PST 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG4a8dbc617d0b: [SSAUpdater] Don't call ValueIsRAUWd upon single use replacement (authored by DaniilSuchkov).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73089/new/

https://reviews.llvm.org/D73089

Files:
  llvm/lib/Transforms/Utils/SSAUpdater.cpp
  llvm/test/Transforms/LCSSA/pr44320.ll


Index: llvm/test/Transforms/LCSSA/pr44320.ll
===================================================================
--- llvm/test/Transforms/LCSSA/pr44320.ll
+++ llvm/test/Transforms/LCSSA/pr44320.ll
@@ -1,4 +1,3 @@
-; XFAIL: *
 ; RUN: opt -passes="verify<scalar-evolution>,lcssa,verify<scalar-evolution>" -verify-scev-strict -S -disable-output %s
 
 ; The first SCEV verification is required because it queries SCEV and populates
Index: llvm/lib/Transforms/Utils/SSAUpdater.cpp
===================================================================
--- llvm/lib/Transforms/Utils/SSAUpdater.cpp
+++ llvm/lib/Transforms/Utils/SSAUpdater.cpp
@@ -195,11 +195,6 @@
   else
     V = GetValueInMiddleOfBlock(User->getParent());
 
-  // Notify that users of the existing value that it is being replaced.
-  Value *OldVal = U.get();
-  if (OldVal != V && OldVal->hasValueHandle())
-    ValueHandleBase::ValueIsRAUWd(OldVal, V);
-
   U.set(V);
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73089.239802.patch
Type: text/x-patch
Size: 934 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200123/5b102c1d/attachment.bin>


More information about the llvm-commits mailing list