[PATCH] D73222: [PGO] Early detection regarding whether pgo counter promotion is possible

Christopher Chrulski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 15:07:48 PST 2020


chris.chrulski marked an inline comment as done.
chris.chrulski added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:328
+  // Counter Promotions.
+  bool isPromotionPossible(Loop *LP) {
     // We can't insert into a catchswitch.
----------------
davidxl wrote:
> You can pass LoopExitBlocks reference as a parameter to this function so that the call to getExitBlocks can be shared with the caller of it.
ok. will do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73222/new/

https://reviews.llvm.org/D73222





More information about the llvm-commits mailing list