[PATCH] D73158: [AArch64TTI] AArch64 supports NT vector stores through STNP.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 14:49:49 PST 2020


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

OK. I think this is good. I honestly wouldn't object to just returning isPowerOf2(DataTypeSize), but the code you have looks better. The real answer, as far as I can tell is any scalar/vector that is a multiple of 64. Like you said with any alignment.

But the vectorizer calls this with kind of silly values, so we have to do the best we can. Anything else will just be turned into a normal store anyway, which isn't particularly bad and I don't think should block vectorization (especially if we start with a store size that would not end up being be non-temporal anyway!)

LGTM. Maybe add a comment about how the vectorizer will call the function with a vector width of 2 (in case that changed in the future, we can see where this logic came from).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73158/new/

https://reviews.llvm.org/D73158





More information about the llvm-commits mailing list