[PATCH] D73204: [NFCI][LoopUnrollAndJam] Minor changes.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 14:13:27 PST 2020


dmgreen added a comment.

Looks like some nice cleanups.



================
Comment at: llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp:384
       for (Instruction &I : *NewBlock) {
-        ::remapInstruction(&I, LastValueMap);
         if (auto *II = dyn_cast<IntrinsicInst>(&I))
----------------
Why does the unroller have it's own version of this function, and how is it different to RemapInstruction?

If this is no longer needs to be shared with the unroller, it can be removed from UnrollLoop.h and made static in LoopUnroll.cpp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73204/new/

https://reviews.llvm.org/D73204





More information about the llvm-commits mailing list