[PATCH] D73222: [PGO] Early detection regarding whether pgo counter promotion is possible

Christopher Chrulski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 13:55:02 PST 2020


chris.chrulski marked an inline comment as done.
chris.chrulski added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:357
+    SmallVector<BasicBlock *, 8> LoopExitBlocks;
+    LP->getExitBlocks(LoopExitBlocks);
+
----------------
davidxl wrote:
> Why this change (changing ExitingBlocks to ExitBlocks)?
Sorry, that was a mistake on my part. Thanks for catching that. I misread that one was setting 'exiting' vs' exit' in the call. will update patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73222/new/

https://reviews.llvm.org/D73222





More information about the llvm-commits mailing list