[PATCH] D73217: [InlineCost] Add flag to allow changing the default inline cost

[Teresa Johnson via llvm-commits]

On Wed, Jan 22, 2020 at 12:51 PM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added a comment.
>
> ok. I see the intention.   As long as the behavior of --inline-threshold
> option is not changed (it still overrides the new option), the new option
> seems fine to me. Adding individually controlled option for size opt seems
> a good idea too.
>

It will affect the behavior of -inline-threshold as the patch currently
stands (the option's value is essentially ignored). That's why I'm
suggesting an alternative to leave -inline-threshold as is, and add a new
bool flag e.g. -inline-threshold-overrides-opt-size, probably defaulted to
true to keep current behavior.

>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D73217/new/
>
> https://reviews.llvm.org/D73217
>
>
>
>

-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200122/cd2a2928/attachment.html>