[PATCH] D73213: [mlir] [VectorOps] Implement vector tuple get folding
Aart Bik via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 22 12:15:06 PST 2020
aartbik added inline comments.
================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:1686
+
+class TupleGetFolder : public OpRewritePattern<TupleGetOp> {
+public:
----------------
aartbik wrote:
> rriddle wrote:
> > Like I said before this should be a fold.
> I had added a question in the prior CL. The tuple is not a constant, and I was following the pattern that was there wrt using a canonicalization.
One folder coming up for Monsieur!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73213/new/
https://reviews.llvm.org/D73213
More information about the llvm-commits
mailing list