[PATCH] D73149: [mlir][Linalg] Add tensor support to Linalg EDSC Builders

[Ahmed S. Taei via Phabricator via llvm-commits]

asaadaldien accepted this revision.
asaadaldien added a comment.
This revision is now accepted and ready to land.

LGTM! clang-format + few nits...



================
Comment at: mlir/lib/Dialect/Linalg/EDSC/Builders.cpp:161
   values.append(inputs.begin(), inputs.end());
-  values.append(outputs.begin(), outputs.end());
+  auto outputBuffersRange = llvm::make_filter_range(
+      outputs, [](StructuredIndexed s) { return s.hasValue(); });
----------------
How about directly inserting into values ? e.g 
```
std::copy_if(s.begin(), s.end(), std::back_inserter(values), [](StructuredIndexed s) {return s.hasValue();});
```


================
Comment at: mlir/lib/Dialect/Linalg/EDSC/Builders.cpp:165
+
+  SmallVector<Type, 4> types;
+  auto outputTensorsRange = llvm::make_filter_range(
----------------
same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73149/new/

https://reviews.llvm.org/D73149