[PATCH] D73213: [mlir] [VectorOps] Implement vector tuple get folding

[Aart Bik via Phabricator via llvm-commits]

aartbik marked an inline comment as done.
aartbik added inline comments.


================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:1686
+
+class TupleGetFolder : public OpRewritePattern<TupleGetOp> {
+public:
----------------
rriddle wrote:
> Like I said before this should be a fold.
I had added a question in the prior CL. The tuple is not a constant, and I was following the pattern that was there wrt using a canonicalization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73213/new/

https://reviews.llvm.org/D73213