[PATCH] D73170: Handle subregs and superregs in callee-saved register mask

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 11:19:14 PST 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:404
+      bool SavedSuper = false;
+      for (MCSuperRegIterator AI(Reg, RegInfo, false); AI.isValid(); ++AI)
+        // Some backends set all aliases for some registers as saved, such as
----------------
fhahn wrote:
> nit: I think you could use MCRegisterInfo::subregs() which is slightly less code.
These masks should eventually be in terms of regunits


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73170/new/

https://reviews.llvm.org/D73170





More information about the llvm-commits mailing list