[PATCH] D73216: [MIPS GlobalISel] Select population count (popcount)

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3922
+
+  Register LoIn = MRI.createGenericVirtualRegister(NarrowTy);
+  Register HiIn = MRI.createGenericVirtualRegister(NarrowTy);
----------------
Assumes NarrowTy == OrigTy / 2. This one should be easy to handle for any divisible type.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3924
+  Register HiIn = MRI.createGenericVirtualRegister(NarrowTy);
+  MIRBuilder.buildUnmerge({LoIn, HiIn}, MI.getOperand(1).getReg());
+
----------------
Can do just buildUnmerge(NarrowTy) assuming it's divisible


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73216/new/

https://reviews.llvm.org/D73216