[PATCH] D73198: [ARM][MVE] Tail-predication: support constant trip count

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 10:32:59 PST 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVETailPredication.cpp:394
 
-  // TODO: Support constant trip counts.
+  // If this is a constant trip count, we directly return this. And if it is a
+  // multiple of the vectorisation factor, the vectoriser should not have
----------------
samparker wrote:
> But the number of elements isn't equal to the trip count!
Ha, the easy case, what a joke. Had myself convinced codegen was okay, but isn't. This indeed needs some more thinking how to approach this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73198/new/

https://reviews.llvm.org/D73198





More information about the llvm-commits mailing list