[PATCH] D73070: Add function attribute "patchable-function-prefix" to support -fpatchable-function-entry=N,M where M>0

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 09:36:48 PST 2020


MaskRay marked 4 inline comments as done.
MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2806
+void AsmPrinter::emitNops(int N) {
+  MCInst Noop;
+  MF->getSubtarget().getInstrInfo()->getNoop(Noop);
----------------
nickdesaulniers wrote:
> guard or `assert` that `N > 0`
Should N==0 be allowed? It does no harm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73070/new/

https://reviews.llvm.org/D73070





More information about the llvm-commits mailing list