[PATCH] D73207: [VE] add, sub, left/right shift isel patterns

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 09:36:46 PST 2020


simoll planned changes to this revision.
simoll marked an inline comment as done.
simoll added a comment.

I'll split off the null_frag changes to the upstream code in a seperate patch before picking this one up again.



================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:258
 
+// RMNDm is similar to RMm without DAG patterns.
+
----------------
arsenm wrote:
> Shouldn't define a different class unless the operand structure is actually different. You can just use a null_frag default parameter to the pattern for example
null_frag works like a charm. I'll rewrite this patch without redundant matcher classes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73207/new/

https://reviews.llvm.org/D73207





More information about the llvm-commits mailing list