[PATCH] D73207: [VE] add, sub, left/right shift isel patterns
    Matt Arsenault via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Jan 22 08:59:52 PST 2020
    
    
  
arsenm added inline comments.
================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:258
 
+// RMNDm is similar to RMm without DAG patterns.
+
----------------
Shouldn't define a different class unless the operand structure is actually different. You can just use a null_frag default parameter to the pattern for example
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73207/new/
https://reviews.llvm.org/D73207
    
    
More information about the llvm-commits
mailing list