[PATCH] D73190: [mlir] Adds affine loop fusion transformation function to LoopFusionUtils.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 08:50:29 PST 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Transforms/Utils/LoopFusionUtils.cpp:258
+  b.clone(*srcForOp.getOperation(), mapper);
+  // Update 'sliceLoopNest' upper and lower bounds from computed 'srcSlice'.
+  SmallVector<AffineForOp, 4> sliceLoops;
----------------
nit: Add newlines before comments.


================
Comment at: mlir/lib/Transforms/Utils/LoopFusionUtils.cpp:272
+  // Promote any single iteration slice loops.
+  for (auto forOp : sliceLoops) {
+    promoteIfSingleIteration(forOp);
----------------
Remove trivial braces.


================
Comment at: mlir/test/lib/Transforms/TestLoopFusion.cpp:193
+      // Gather all AffineForOps by loop depth.
+      for (auto &block : getFunction()) {
+        gatherLoops(&block, /*currLoopDepth=*/0, depthToLoops);
----------------
Remove trivial braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73190/new/

https://reviews.llvm.org/D73190





More information about the llvm-commits mailing list