[PATCH] D70708: [AMDGPU] Simplify test and extend to gfx9 and gfx10

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 08:50:28 PST 2020


arsenm added inline comments.
Herald added a subscriber: kerbowa.


================
Comment at: llvm/test/CodeGen/AMDGPU/vccz-corrupt-bug-workaround.mir:60
-selected:        false
-tracksRegLiveness: true
-liveins:
----------------
foad wrote:
> arsenm wrote:
> > Losing tracksRegLiveness seem like a problem, since this is a case where you're using reg liveness (along with the loss of the liveins lists)
> I can put `tracksRegLiveness` back in of course, but are you saying the insert waitcnts pass depends on liveness? I wasn't aware of that.
It has to check if vccz is live out for example. Not tracking liveness at any point is just insane


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70708/new/

https://reviews.llvm.org/D70708





More information about the llvm-commits mailing list