[PATCH] D73122: [mlir] Enable specifying verify on OpInterface

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/IR/OpBase.td:1417
+
+  // Specify the body of the verification function. `$_op` will be replaced with
+  // the operation being verified.
----------------
jpienaar wrote:
> rriddle wrote:
> > Why the underscore?
> To match the same placeholder in line 79. I was tempted to just document that `op` will refer to the op, but given we already have those placeholders, kept it consistent.
This isn't consistent with the rest of the OpInterface methods though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73122/new/

https://reviews.llvm.org/D73122