[PATCH] D72829: Implement -fsemantic-interposition

[serge via Phabricator via llvm-commits]

serge-sans-paille added a comment.

> I tried modifying `GlobalValue::maybeSetDsoLocal`: `setDSOLocal(true)` for ExternalLinkage. Unfortunately that will break 1337 tests. If not so many tests need fixing, I wish we can place `getParent() && getParent()->getSemanticInterposition()` logic in `maybeSetDsoLocal` and simplify `isInterposable`.

Tried that and ended up with various check failures.
I also tried to update isInterposableLinkage to either

- set more linkage type as interposable unconditionnaly, and with no surprise, it triggers plenty check failures
- accept a mandatory « `HonorSemanticInterposition` argument, so that both `isInterposableLinkage` and `isInterposable` are consistent, but in some cases, `isInterposableLinkage` doesn't have a module reference to gather the ModuleFlag from...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72829/new/

https://reviews.llvm.org/D72829