[PATCH] D73193: [llvm-readelf] - Improve dumping of objects without a section header string table.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 07:02:57 PST 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar retitled this revision from "[llvm-readelf] - Improve dumping of objects without section header string table." to "[llvm-readelf] - Improve dumping of objects without a section header string table.".

We have a test/Object/no-section-header-string-table.test which checks
what happens when an object does not have a section header string table.
It does not check the full output though.
Currently out output is different from GNU readelf, because the latter prints
"<no-strings>" instead of a section name, while we print nothing.

This patch fixes this, adds a proper test case and removes the one from test/Object,
as it is not a right folder for llvm-readelf tests.


https://reviews.llvm.org/D73193

Files:
  llvm/test/Object/Inputs/no-section-header-string-table.elf-x86-64
  llvm/test/Object/no-section-header-string-table.test
  llvm/test/tools/llvm-readobj/ELF/sections-no-section-header-string-table.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73193.239583.patch
Type: text/x-patch
Size: 4058 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200122/d6e329e1/attachment.bin>


More information about the llvm-commits mailing list