[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

Wed Jan 22 05:38:00 PST 2020

ikudrin added inline comments.

================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h:52
+    //   a 64-bit DWARF format macro section
+    uint32_t DebugLineOffset;
+  };
----------------
SouraVX wrote:
> ikudrin wrote:
> > Make this field `uint64_t` so that it will be compatible with 64-bit DWARF from the beginning. Changing it later is always more difficult and error-prone.
> Hi @ikudrin Thanks for reviewing this. Even I'm confused here about `DWARF32`, `DWARF64`. For instance here to access `debug_str` section Offset in `uint64_t` that means `debug_str` is already `DWARF64`. ?? 
> Even, while accessing macro, I've used `uint64_t Offset`, is it wrong ?? If macro section is already DWARF64, then I've have correct generartion patch `D72828` also to emit DWARF64 in macro header.
> 
> Can somebody help/explain this. ?? @probinson @aprantl 
> Spec Pg. 144 Section 6.1.1.4.2 says ->
> "DWARF-32 format, a section offset is 4 bytes, while in the DWARF-64 format, a section offset is 8 bytes."
> 
You don't need to implement the support for DWARF64 right now, at least in this patch. DWARF32 is the most popular and, as such, a more important format. Support for DWARF64 may be added later.

Anyway, it is better to be ready for it to minimize rewritings in the future.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086