[PATCH] D73167: Don't separate imp/expl def handling for call site params
Djordje Todorovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 22 03:58:23 PST 2020
djtodoro accepted this revision.
djtodoro added a comment.
This revision is now accepted and ready to land.
Looks good to me (nit included)!
Thanks for the code clean up!
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:636
- SmallVector<unsigned, 4> ExplicitFwdRegDefs;
- SmallVector<unsigned, 4> ImplicitFwdRegDefs;
- getForwardingRegsDefinedByMI(*I, ExplicitFwdRegDefs, ImplicitFwdRegDefs);
- if (ExplicitFwdRegDefs.empty() && ImplicitFwdRegDefs.empty())
+ SmallSetVector<unsigned, 4> FwdRegDefs;
+ getForwardingRegsDefinedByMI(*I, FwdRegDefs);
----------------
Perhaps we should add a comment here describing what the `FwdRegDefs` is used for, or rename the variable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73167/new/
https://reviews.llvm.org/D73167
More information about the llvm-commits
mailing list