[PATCH] D73164: [llvm-readobj][test] - Add a check for --dyn-syms.

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar edited the summary of this revision.
grimar edited the summary of this revision.

We have the `-dyn-symbols` option. It has a `--dyn-syms` alias
that is not tested in llvm-readobj tests currently.

There is a Object/readobj-elf-versioning.test where it is used,
but I am removing it in D73163 <https://reviews.llvm.org/D73163>. And also it is not the
right place to test it anyways.


https://reviews.llvm.org/D73164

Files:
  llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test


Index: llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
===================================================================
--- llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
+++ llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
@@ -69,11 +69,19 @@
     Sections:
       - Section: .dynsym
 
-## Case 2: Check the two-letter alias --dt is equivalent to the --dyn-symbols
+## Case 2: Check the output for aliases.
+## a) Check the two-letter alias --dt is equivalent to the --dyn-symbols
 ## full flag name.
 # RUN: llvm-readobj --dt %t1.so > %t.readobj-dt-alias
 # RUN: llvm-readobj --dyn-symbols %t1.so > %t.readobj-dt-no-alias
 # RUN: cmp %t.readobj-dt-alias %t.readobj-dt-no-alias
+## b) Check --dyn-syms equals --dyn-symbols, --dt for llvm-readobj.
+# RUN: llvm-readobj --dyn-syms %t1.so > %t.readobj-dyn-syms
+# RUN: cmp %t.readobj-dt-alias %t.readobj-dyn-syms
+## c) Check --dyn-syms equals --dyn-symbols for llvm-readelf.
+# RUN: llvm-readelf --dyn-syms %t1.so > %t.readelf-dyn-syms
+# RUN: llvm-readelf --dyn-symbols %t1.so > %t.readelf-dyn-symbols
+# RUN: cmp %t.readelf-dyn-symbols %t.readelf-dyn-syms
 
 ## Case 3: Check that we are able to dump the dynamic symbol table even when we have no program headers.
 ## In this case we find the table by it's type (SHT_DYNSYM) and ignore the DT_SYMTAB value.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73164.239519.patch
Type: text/x-patch
Size: 1317 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200122/ed4d6e1a/attachment.bin>