[PATCH] D72887: [lsan] Support LeakSanitizer runtime on Fuchsia

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/lsan/lsan_posix.cpp:18
+#include "lsan.h"
+#include "lsan_allocator.h"
+#include "sanitizer_common/sanitizer_stacktrace.h"
----------------
Could you please move ThreadContext refactoring into a separate patch?


================
Comment at: compiler-rt/lib/lsan/lsan_thread.cpp:26
 
-static ThreadRegistry *thread_registry;
+ThreadRegistry *thread_registry;
 
----------------
lets keep in static


================
Comment at: compiler-rt/lib/lsan/lsan_thread.cpp:74
 
-u32 ThreadCreate(u32 parent_tid, uptr user_id, bool detached) {
-  return thread_registry->CreateThread(user_id, detached, parent_tid,
----------------
can you return ThreadCreate and ThreadStart to keep thread_registry static?
maybe as:
void ThreadStart(u32 tid, tid_t os_id, void *arg) {


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72887/new/

https://reviews.llvm.org/D72887