[PATCH] D73000: [InstCombine] Optimize strchr(cststr, C)
    Johannes Doerfert via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jan 21 17:44:11 PST 2020
    
    
  
jdoerfert added a comment.
In D73000#1832174 <https://reviews.llvm.org/D73000#1832174>, @lebedev.ri wrote:
> Nitpick: regardless of any further potential folds, is this particular fold always a win?
>  Is there some potential pattern where this will not/can not get as nicely folded as it does in the newly added tests?
Maybe if the string is made up of far apart chars: "ahpzDKOTZ"
Though if we can verify it becomes a switch it might still be better.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73000/new/
https://reviews.llvm.org/D73000
    
    
More information about the llvm-commits
mailing list